Draft
Conversation
Member
Author
|
Depends on actix/actix-net#397 FnOnce was chosen for the closure because otherwise it would be incovenient to use - the users are required to clone captures before the async block: HttpServer::new_async(move || {
let data = data.clone();
async move { App::new().data(data) }
})
|
Member
|
not pursuing async server builders this cycle so delaying this til post v4 |
aliemjay
force-pushed
the
web/feat/httpserver-new-async
branch
from
33ce81a to
4b098d3
Compare
aliemjay
added
B-semver-major
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
Closes #2286